Java modernization with Claude#38
Merged
Merged
Conversation
Only call configureApacheConnector() when the connector is actually an ApacheConnectorProvider. This prevents Apache-specific configuration (connection pool size, socket timeout, etc.) from being applied to non-Apache connectors like HttpUrlConnectorProvider.
xiaoxin-ren
approved these changes
Jun 24, 2026
xiaoxin-ren
left a comment
xiaoxin-ren
left a comment
Contributor
There was a problem hiding this comment.
Generally LGTM. Please test thoroughly together with ecs-object-client-java on Java 25 VM, and make sure no regression.
Collaborator
|
We have tested all testcases are passing and no regression that we have confirmed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.